[Aikido] Fix 9 security issues in path-to-regexp, undici#129
Open
aikido-autofix[bot] wants to merge 1 commit intomainfrom
Open
[Aikido] Fix 9 security issues in path-to-regexp, undici#129aikido-autofix[bot] wants to merge 1 commit intomainfrom
aikido-autofix[bot] wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade path-to-regexp and undici to fix HTTP request smuggling, WebSocket DoS via decompression bombs and invalid parameters, and header injection vulnerabilities.
✅ Code not affected by breaking changes.
No breaking changes from either package upgrade affect this codebase:
undici (6.23.0 => 7.24.1):
The package is only used as a transitive dependency through
@actions/*packages (visible inpackage-lock.json)No direct imports or usage of
undicifound in the source codeThe
throwOnErroroption is not used anywhere in the codebaseNo interceptors are configured or used in the source code
The deduplicate interceptor is not used
Node.js version requirement is
>=20(package.json), which satisfies undici 7.x's requirement of Node.js >= 18.17path-to-regexp (8.2.0 => 8.4.0):
Used as a transitive dependency through
express(visible inpackage-lock.json)All route patterns in the codebase are simple static paths (e.g.,
/api/runtime/config,/api/runtime/apps/down)No wildcard patterns (
*) are used in route definitionsNo optional route groups are present in the route patterns
The changes restricting wildcard backtracking and optional route combinations do not apply to the simple route patterns used in this codebase
All breaking changes by upgrading path-to-regexp from version 8.2.0 to 8.4.0 (CHANGELOG)
All breaking changes by upgrading undici from version 6.23.0 to 7.24.1 (CHANGELOG)
fix(deduplicate): do not deduplicate non-safe methods by default- This changes the default behavior of the deduplicate interceptor to no longer deduplicate non-safe HTTP methods, which could cause previously deduplicated requests to now be sent multiple times.✅ 9 CVEs resolved by this upgrade
This PR will resolve the following CVEs:
__proto__orconstructor, potentially influencing application behavior or enabling further attacks.__proto__,constructor, orprototypeinto internal objects, potentially modifying the prototype chain and influencing application behavior or enabling further attacks.🔗 Related Tasks