add benchmark tooling + docs + CI integration by GlenDC · Pull Request #82 · AikidoSec/safechain-internals

GlenDC · 2026-01-29T23:08:38Z

Ready for feedback on the initial version of benchmarking support for proxy code.

Summary by Aikido

⚠️ Security Issues: 2	🔍 Quality Issues: 13	Resolved Issues: 0

🚀 New Features

Added blocked-event notifier and injected x-blocked-by header on blocks.

⚡ Enhancements

Introduced configurable WebClientConfig and transport module for web clients.
Added telemetry and env utilities including TelemetryConfig and server_identifier.

🔧 Refactors

Replaced DomainTrie with DomainMatcher across firewall rules and logic.
Refactored proxy server into ProxyServer builder and extracted HTTP creator.

^{More info}

improve egress connection pool parameters

proxy_netbench/src/cmd/run/mod.rs

proxy_netbench/run.py

proxy_netbench/src/cmd/run/mod.rs

proxy_netbench/src/cmd/emulate/export.rs

proxy_netbench/src/cmd/emulate/filters/mod.rs

proxy_netbench/src/cmd/emulate/filters/range.rs

if you do use unwrap/expect you need to allow it and hopefully with a good reason

proxy_netbench/src/cmd/emulate/filters/mod.rs

proxy_netbench/src/main.rs

proxy_netbench/src/cmd/emulate/filters/path.rs

… dns

proxy/src/client/transport.rs

GlenDC · 2026-02-01T00:18:07Z

Ready for review @bitterpanda63 .
We can go through it together if you have questions.

It's a bit of a big one. I usually try to prevent these.
But I think it's warranted here.

proxy/src/cli.rs

bitterpanda63 · 2026-02-04T14:57:05Z

proxy/Cargo.toml

-version = "0.1.0"
-edition = "2024"
+name = "safechain-proxy-lib"
+description = "Core library for safechain-proxy (cli)"


why cli here?

bitterpanda63 · 2026-02-04T15:01:11Z

proxy/src/firewall/malware_list.rs


 pub type EntryFormatter = Arc<dyn MalwareListEntryFormatter>;

+pub const MALWARE_LIST_URI_STR_VSCODE: &str = "https://malware-list.aikido.dev/malware_vscode.json";


instead of reverting I will just make small Prs for all these things individually. Afterwards I will simply get it merged into this branch again, from main.

GlenDC · 2026-02-04T17:54:30Z

Demoted to draft again until all parts out of scope are merged into main via separate PRs or removed

GlenDC added 30 commits January 22, 2026 11:08

initial netbench cli code

20c635e

generate client requests

5241116

minor patch

466157f

Merge branch 'main' into feat/netbench

3e291a6

prepare code for proxy reusage and similar codebase refactor

96f451a

Merge branch 'main' into feat/netbench

50f357b

migrate from main

d163dc9

integrate proxy in netbench tool

12139f5

reuse malware list download from safechain-proxy-lib

59daa3f

support egress overwrite (bench only)

153cf10

improve egress connection pool parameters

remove unused deps (in netbench)

0b633ff

improve numbers for bench runs

59b386c

add tests for newly introduced utils

cb77b1c

add+support netbench mock server impl

17c2e06

Merge branch 'feat/netbench'

69dde14

finish off mock server netbench

1dc890f

improve proxy mock address support

27139d3

pre-generate ok payloads for mock server

de83f70

ensure forward traffic is also going to mock server

1807f29

add large payload for mock test that is highly compressable

434240e

improve mock payload + related headers

62d46eb

support HAR replay in mock server

92c849f

update rama deps

ca27cb3

bump rama

e5c082c

prepare runner code to be able to also use replay

cd97eeb

Merge branch 'main' into feat/netbench

70b1f10

Merge branch 'main' into feat/netbench

06c9e88

Merge branch 'main' into feat/netbench

20a96f8

Merge branch 'main' into feat/netbench

36ca9d8

ensure proxy_fuzz makes now use of safechain-proxy-lib

d5f06ed

aikido-pr-checks bot reviewed Jan 31, 2026

View reviewed changes

proxy_netbench/src/cmd/run/mod.rs Outdated Show resolved Hide resolved

merge main + address feedback aikibot part 3

130062c

aikido-pr-checks bot reviewed Jan 31, 2026

View reviewed changes

proxy_netbench/run.py Show resolved Hide resolved

aikido-pr-checks bot reviewed Jan 31, 2026

View reviewed changes

proxy_netbench/run.py Show resolved Hide resolved

aikido-pr-checks bot reviewed Jan 31, 2026

View reviewed changes

proxy_netbench/run.py Show resolved Hide resolved

aikido-pr-checks bot reviewed Jan 31, 2026

View reviewed changes

proxy_netbench/run.py Show resolved Hide resolved

aikido-pr-checks bot reviewed Jan 31, 2026

View reviewed changes

proxy_netbench/src/cmd/run/mod.rs Show resolved Hide resolved

GlenDC added 5 commits January 31, 2026 14:18

fix CI benchmark + address more feedback

ebf7506

prepare netbench emulate to also handle har replays

792e5a6

add remaining todo

44c4744

support filters in emulate cmd

a4a3b6f

add har request e2e tests (made with emulate cmd of netbench)

a690ce8

aikido-pr-checks bot reviewed Jan 31, 2026

View reviewed changes

proxy_netbench/src/cmd/emulate/export.rs Show resolved Hide resolved

aikido-pr-checks bot reviewed Jan 31, 2026

View reviewed changes

proxy_netbench/src/cmd/emulate/filters/mod.rs Show resolved Hide resolved

aikido-pr-checks bot reviewed Jan 31, 2026

View reviewed changes

proxy_netbench/src/cmd/emulate/filters/range.rs Show resolved Hide resolved

aikido-pr-checks bot reviewed Jan 31, 2026

View reviewed changes

proxy_netbench/src/cmd/emulate/filters/range.rs Show resolved Hide resolved

GlenDC added 2 commits February 1, 2026 00:49

improve code + separate proxy troubleshooting doc

3f94f47

fix transport bench (dns) + disallow unwraps/expects

abc81a8

if you do use unwrap/expect you need to allow it and hopefully with a good reason

aikido-pr-checks bot reviewed Jan 31, 2026

View reviewed changes

proxy_netbench/src/cmd/emulate/filters/mod.rs Show resolved Hide resolved

aikido-pr-checks bot reviewed Jan 31, 2026

View reviewed changes

proxy_netbench/src/main.rs Show resolved Hide resolved

aikido-pr-checks bot reviewed Jan 31, 2026

View reviewed changes

proxy_netbench/src/cmd/emulate/filters/path.rs Show resolved Hide resolved

fix dns in bench to ensure for non-overwritten paths we do use global…

7bcbb46

… dns

aikido-pr-checks bot reviewed Feb 1, 2026

View reviewed changes

proxy/src/client/transport.rs Show resolved Hide resolved

GlenDC mentioned this pull request Feb 4, 2026

Bump bytes from 1.11.0 to 1.11.1 #89

Open

bitterpanda63 reviewed Feb 4, 2026

View reviewed changes

proxy/src/cli.rs Show resolved Hide resolved

bitterpanda63 reviewed Feb 4, 2026

View reviewed changes

GlenDC marked this pull request as draft February 4, 2026 17:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add benchmark tooling + docs + CI integration#82

add benchmark tooling + docs + CI integration#82
GlenDC wants to merge 60 commits intomainfrom
feat/netbench

GlenDC commented Jan 29, 2026 •

edited by aikido-pr-checks bot

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GlenDC commented Feb 1, 2026

Uh oh!

Uh oh!

bitterpanda63 Feb 4, 2026

Uh oh!

bitterpanda63 Feb 4, 2026

Uh oh!

GlenDC Feb 4, 2026

Uh oh!

GlenDC commented Feb 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		pub type EntryFormatter = Arc<dyn MalwareListEntryFormatter>;

		pub const MALWARE_LIST_URI_STR_VSCODE: &str = "https://malware-list.aikido.dev/malware_vscode.json";

Conversation

GlenDC commented Jan 29, 2026 • edited by aikido-pr-checks bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by Aikido

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GlenDC commented Feb 1, 2026

Uh oh!

Uh oh!

bitterpanda63 Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

bitterpanda63 Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

GlenDC Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

GlenDC commented Feb 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

GlenDC commented Jan 29, 2026 •

edited by aikido-pr-checks bot

Loading