[Parked] MacOS installer improvements #83
Conversation
- Adjusted uninstall script to reference the new app bundle structure. - Updated platform configuration to use a base directory for paths. - Modified build script to create an app bundle with necessary directories and resources. - Added icon generation script for creating the application icon from SVG. - Created Info.plist for the app bundle to define application metadata. - Updated LaunchDaemon plist to reflect new binary path within the app bundle.
- Removed hardcoded base directory constant in favor of direct paths for binaries and logs. - Updated build script to copy binaries into the app bundle's Contents/MacOS directory. - Adjusted post-installation and uninstall scripts to reflect new binary locations within the app bundle. - Enhanced permissions handling for binaries in the app bundle structure.
- Refactored installation paths to streamline the app bundle structure. - Updated uninstall and post-install scripts to reference the new app bundle and binary locations. - Adjusted permissions handling for binaries in the new directory layout. - Enhanced the build script to create necessary directories for the application.
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
| chmod 644 "$LOGS_DIR/.keep" | ||
|
|
||
| # Copy binaries | ||
| # Copy binaries into app bundle |
There was a problem hiding this comment.
Comment only restates the following cp/chmod operations. Remove or replace with a 'why' comment explaining why binaries are placed in the app bundle (e.g., purpose or constraint).
Details
✨ AI Reasoning
A comment was modified to "# Copy binaries into app bundle" directly above three cp and chmod commands. The comment only restates the mechanical action (copying binaries) already explicit in the following commands. It provides no rationale (why binaries go here) or design constraints. This increases comment noise without adding maintainable context.
🔧 How do I fix it?
Write comments that explain the purpose, reasoning, or business logic behind the code using words like 'because', 'so that', or 'in order to'.
Reply @AikidoSec feedback: [FEEDBACK] to get better review comments in the future.
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info
- Changed binary permission settings to point to the INSTALL_DIR instead of the app bundle's Contents/MacOS directory. - Ensured proper permissions are set for the binaries in the updated directory structure.
…hain Ultimate - Changed the path in the preuninstall script to point to the new binary location in the 'bin' directory instead of the app bundle's Contents/MacOS directory. - Ensured the teardown process runs correctly with the updated path.
tudor-timcu
changed the title
1 participant
Summary by Aikido
🚀 New Features
⚡ Enhancements
More info