Skip to content

Add linting - #64

Open
timokoessler wants to merge 7 commits into
mainfrom
add-linting
Open

timokoessler wants to merge 7 commits into
mainfrom
add-linting

Conversation

@timokoessler

Copy link
Copy Markdown
Member

No description provided.

@timokoessler
timokoessler marked this pull request as ready for review January 27, 2025 09:17
Comment thread .github/workflows/lint.yml Outdated
Co-authored-by: Hans Ott <hansott@hotmail.be>
match tokenizer.tokenize() {
Ok(tokens) => tokens, // Return the tokens if successful
Err(_e) => {
Vec::new() // Return empty vector if unsuccessfull.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use this place often to add a dbg!(_e) statement 😬

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed back and added a linter ignore comment.

Whitespace::MultiLineComment(_) => true,
_ => false,
};
let whitespace_is_comment = matches!(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

covered?

Comment thread src/ffi_bindings/mod.rs
/// This function should only be called with valid pointers to C strings.
#[no_mangle]
pub extern "C" fn detect_sql_injection(
pub unsafe extern "C" fn detect_sql_injection(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

required?

@codecov-commenter

codecov-commenter commented Jan 27, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 96.96970% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/sql_injection/have_comments_changed.rs 66.66% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

…nting

* 'main' of github.com:AikidoSec/zen-internals:
  Add comments
  Ignore ffi and wasm bindings module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants