fix: potential fix for member parsing causing ac to silently fail #750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lulalaby
requested review from
JMLutra,
VincentRPS,
byterand and
fthomys
and removed request for
JMLutra,
VincentRPS and
fthomys
Lulalaby
force-pushed
the
fix/internal-nre
branch
from
24829eb to
dbe9efc
Compare
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in application command (AC) member parsing that was causing commands to fail silently. The issue occurred when resolved members in interactions didn't have their ManualUser property initialized, leading to null reference exceptions when accessing member user data.
Key Changes:
- Fixed member parsing in interaction resolution by ensuring
ManualUseris properly initialized before accessing member user properties - Added
GuildDisplayNameStylesproperty to support guild-specific display name styling - Corrected JSON serialization by adding
JsonIgnoreto the overriddenDisplayNameStylesproperty to prevent conflicts
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| DisCatSharp/Entities/Guild/DiscordMember.cs | Added GuildDisplayNameStyles property, corrected documentation comments for guild-specific properties, and added JsonIgnore to DisplayNameStyles override |
| DisCatSharp/Clients/DiscordClient.Dispatch.cs | Fixed member parsing bug by initializing ManualUser property before accessing User property in resolved members, simplified null-conditional access for PartialGuild |
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.