refactor: address code review feedback on invite target users feature #757
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Lulalaby <[email protected]>
…ream Co-Authored-By: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Lulalaby <[email protected]>
Copilot
AI
changed the title
[WIP] Add support for invite target user allowlists and job status
refactor: address code review feedback on invite target users feature
Jan 22, 2026
Lulalaby
requested review from
cking and
xMaxximum
and removed request for
a team
Lulalaby
added a commit
that referenced
this pull request
Jan 22, 2026
…756) * feat: add support for invite target user allowlists and job status Introduces methods and endpoints to manage allowlists of users who can accept invites, including CSV-based and user ID-based updates. Adds the ability to query the processing status of invite target user jobs, updates the invite creation API to support role grants and target user restrictions, and implements supporting types and utilities for these features. * Rename Values to SelectedValues in checkbox group Renamed the 'Values' property to 'SelectedValues' in DiscordCheckboxGroupComponent to improve clarity and better reflect its purpose. * refactor: address code review feedback on invite target users feature (#757) * Initial plan * docs: improve documentation and code quality for invite target users Co-Authored-By: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Lulalaby <[email protected]> * fix: prevent memory leak by not resetting internally-created MemoryStream Co-Authored-By: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Lulalaby <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Lulalaby <[email protected]> * Dispose targetUsersCsv streams after use Added try-catch blocks to dispose the targetUsersCsv streams in CreateChannelInviteAsync and UpdateInviteTargetUsersAsync methods to ensure proper resource cleanup and prevent potential memory leaks. --------- Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses code review feedback from #756 focusing on documentation clarity, code quality, and a memory leak in stream disposal.
Type of change
Changes
Documentation
MergeTargetUserIdsandBuildTargetUsersCsvFileUpdateInviteTargetUsersAsync(header line must be "Users", one ID per subsequent line)ParseTargetUsersCsvCanReadcheck) inCreateInviteAsyncwith exception documentationBug Fixes
resetPositionTo: 0toresetPositionTo: nullfor internally-created MemoryStreams inBuildTargetUsersCsvFileUpdateInviteTargetUsersAsync(could be any of 3 parameters)Code Quality
Where(),Select()) instead of implicit filtering in loopsBuildTargetUsersCsvFile,MergeTargetUserIds,ParseTargetUsersCsvHow Has This Been Tested?
Test Configuration:
Checklist:
@Aiko-IT-Systems/discatsharp
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.