Open
Conversation
runwuf
force-pushed
the
fwu-client-cert-auth
branch
from
7c889e8 to
87afc74
Compare
alexole
requested changes
Sep 13, 2022
ghost
suggested changes
Sep 13, 2022
runwuf
force-pushed
the
fwu-client-cert-auth
branch
from
670e0aa to
1a3f4a9
Compare
alexole
previously requested changes
Sep 15, 2022
Contributor
alexole
left a comment
alexole
left a comment
There was a problem hiding this comment.
Left a couple of comments and also, please cover new functionality with tests,
runwuf
force-pushed
the
fwu-client-cert-auth
branch
from
1a3f4a9 to
2cde254
Compare
runwuf
dismissed
alexole’s stale review
Changes have been done, but tests outstanding. A JIRA request has been submitted if BF team could finish up the rest including avn cli. Thank you.
paulwouters
approved these changes
Apr 12, 2023
Comment on lines
+77
to
+79
| * `SOURCE_SSL_CA` - The path name of the Certificate Authority (CA) certificate file in PEM format. | ||
| * `SOURCE_SSL_CERT` - The path name of the server SSL public key certificate file in PEM format. | ||
| * `SOURCE_SSL_KEY` - The path name of the server SSL private key file in PEM format. |
There was a problem hiding this comment.
should these be SOURCE_SERVICE_SSL_XXX to match the other keywords better?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade pymysql to 1.0.2 is required.