Add Http Method configuration. That will be used for sending data to target.#198
Open
ecararus wants to merge 4 commits intoAiven-Open:mainfrom
Open
Add Http Method configuration. That will be used for sending data to target.#198ecararus wants to merge 4 commits intoAiven-Open:mainfrom
ecararus wants to merge 4 commits intoAiven-Open:mainfrom
Conversation
… endpoint, Defaulted on POST Method. Supported POST/PUT
ecararus
changed the title
Fix linter reported issue
Fix Linter reported issue
Fix Linter reported issue
jeqo
requested changes
Nov 1, 2023
Contributor
jeqo
left a comment
jeqo
left a comment
There was a problem hiding this comment.
Thanks @ecararus! Overall, this improvement looks good to add into the connector.
I added a few comments on the config enum and few other nits. Let me know if anything is unclear.
PS. To test checkstyle locally that have been failling, you can run ./gradlew checkstyleMain checkstyleTest
Comment on lines
+28
to
+40
| public final String name; | ||
|
|
||
| HttpMethodsType(final String name) { | ||
| this.name = name; | ||
| } | ||
|
|
||
| public static HttpMethodsType forName(final String name) { | ||
| Objects.requireNonNull(name); | ||
| return Arrays.stream(values()) | ||
| .filter(v -> v.name.equalsIgnoreCase(name)) | ||
| .findFirst() | ||
| .orElseThrow(() -> new IllegalArgumentException("HTTP Method type: " + name)); | ||
| } |
Contributor
There was a problem hiding this comment.
I think we can stick to just use the Enum name, and remove the attribute. See OAuth2AuthorizationMode which already support a configuration.
Comment on lines
+58
to
+64
| switch (config.httpMethod()) { | ||
| case POST: | ||
| return httpRequestBuilder | ||
| .build(config).POST(HttpRequest.BodyPublishers.ofString(body)); | ||
| case PUT: | ||
| return httpRequestBuilder | ||
| .build(config).PUT(HttpRequest.BodyPublishers.ofString(body)); |
Contributor
There was a problem hiding this comment.
let's move the repeated code up
Suggested change
| switch (config.httpMethod()) { | |
| case POST: | |
| return httpRequestBuilder | |
| .build(config).POST(HttpRequest.BodyPublishers.ofString(body)); | |
| case PUT: | |
| return httpRequestBuilder | |
| .build(config).PUT(HttpRequest.BodyPublishers.ofString(body)); | |
| final var httpRequest = httpRequestBuilder.build(config); | |
| switch (config.httpMethod()) { | |
| case POST: | |
| return httpRequest.POST(HttpRequest.BodyPublishers.ofString(body)); | |
| case PUT: | |
| return httpRequest.PUT(HttpRequest.BodyPublishers.ofString(body)); |
|
|
||
| } | ||
|
|
||
|
|
| // Check the messages have been sent once | ||
| messages.forEach( | ||
| message -> bodyPublishers.verify(() -> HttpRequest.BodyPublishers.ofString(eq(message)), times(1))); | ||
|
|
| .get(as(InstanceOfAssertFactories.DURATION)) | ||
| .hasSeconds(config.httpTimeout()); | ||
| assertThat(httpRequest.method()).isEqualTo("POST"); | ||
| assertThat(httpRequest.method()).isEqualTo(HttpMethodsType.POST.name()); |
Contributor
There was a problem hiding this comment.
We can stick to the string values here, so if enum changes, then tests will fail. Same for new put tests
Comment on lines
+51
to
53
| final var requestBuilder = prepareRequest(body); | ||
| return sendWithRetries(requestBuilder, HttpResponseHandler.ON_HTTP_ERROR_RESPONSE_HANDLER, | ||
| config.maxRetries()); |
Contributor
There was a problem hiding this comment.
We can improve the naming here
Suggested change
| final var requestBuilder = prepareRequest(body); | |
| return sendWithRetries(requestBuilder, HttpResponseHandler.ON_HTTP_ERROR_RESPONSE_HANDLER, | |
| config.maxRetries()); | |
| final var request = prepareRequest(body); | |
| return sendWithRetries(request, HttpResponseHandler.ON_HTTP_ERROR_RESPONSE_HANDLER, config.maxRetries()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add configuration for HTTP Method for the target endpoint.
Default is POST supported values: [POST/PUT]