Skip to content

Change wait_select default timeout to 10 seconds #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
orange-kao wants to merge 1 commit into from
Closed

Change wait_select default timeout to 10 seconds #127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pglookout/cluster_monitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ class ReplicationSlot:
state_data: str


def wait_select(conn, timeout=5.0):
def wait_select(conn, timeout=10.0):
Copy link

@tkren tkren Jul 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's bump this to 15s: https://aiven.atlassian.net/browse/PM-5174 required > 12s timeout. Eventually, this should be configurable or exponential backoff retrying instead of constantly staying put.

end_time = time.monotonic() + timeout
while time.monotonic() < end_time:
time_left = end_time - time.monotonic()
Expand Down