zstdfile: ensure we do not read more than size / IO_BLOCK_SIZE#217
Merged
Khatskevich merged 1 commit intomainfrom Dec 23, 2025
Merged
zstdfile: ensure we do not read more than size / IO_BLOCK_SIZE#217Khatskevich merged 1 commit intomainfrom
Khatskevich merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses memory spikes during zstd decompression by refactoring the _ZtsdFileReader class to use ZstdDecompressor.stream_reader() instead of decompressobj(). The new approach enables incremental decompression with a bounded output buffer, ensuring that read() operations respect the requested size parameter and do not produce arbitrarily large outputs.
- Replaced
decompressobj()withstream_reader()for controlled, incremental decompression - Modified the
read()method to honor size parameter and limit output to requested bytes - Added comprehensive test coverage for compression and decompression with size-bounded reads
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| rohmu/zstdfile.py | Refactored _ZtsdFileReader to use stream_reader() for bounded decompression and updated read() method to respect size parameter |
| test/test_zstdfile.py | Added new test case validating compression/decompression with size-limited reads to verify the fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c8f5835 to
b80c669
Compare
In the previous implementation, _ZtsdFileReader.read could produce output of arbirary size. This can cause memory spikes while decompressing a file. Instead, we should use a ZstdDecompressor.stream_reader which decompresses incrementally into a fixed size output buffer.
b80c669 to
5406382
Compare
Khatskevich
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the previous implementation, _ZtsdFileReader.read could produce output of arbirary size. This can cause memory spikes while decompressing a file. Instead, we should use a ZstdDecompressor.stream_reader which decompresses incrementally into a fixed size output buffer.
About this change - What it does
Resolves: #xxxxx
Why this way