Adding support for optional and schemaless keys/values#724
Open
AnatolyPopov wants to merge 1 commit intomainfrom
Open
Adding support for optional and schemaless keys/values#724AnatolyPopov wants to merge 1 commit intomainfrom
AnatolyPopov wants to merge 1 commit intomainfrom
Conversation
ivanyu
reviewed
Aug 25, 2025
| Schema.createUnion(Schema.create(Schema.Type.NULL), | ||
| (Schema) valueDeserializer.getSchemaRegistryClient().getSchemaById(schemaId).rawSchema()), | ||
| schemaId); | ||
| } catch (final RestClientException e) { |
Contributor
There was a problem hiding this comment.
Don't generic network errors fall into this category?
Contributor
Author
There was a problem hiding this comment.
I believe yes but AFAIU it will be thrown only after exhausting all the allowed retry attempts. Or am I missing anything?
Contributor
There was a problem hiding this comment.
I think if a network error happens, the plugin should fail as well. The result of this function cannot depend on network or schema registry availability.
AnatolyPopov
force-pushed
the
anatolii/optional-key-value-schema
branch
from
23fcc5b to
4ec4590
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making key and value schemas optional