-
Notifications
You must be signed in to change notification settings - Fork 342
feat: add Nuxt 4 support #1092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add Nuxt 4 support #1092
Conversation
Expand @nuxt/kit peer dependency to accept both ^3.2.0 and ^4.0.0
✅ Deploy Preview for v-tooltip ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @8bu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a peer dependency conflict that previously prevented Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly adds support for Nuxt 4 by updating the @nuxt/kit peer dependency in package.json to allow both version 3 and 4. The change is well-explained and follows a common pattern for supporting multiple major versions. The change is correct and I have no specific comments on the implementation. As a general suggestion for improving the project's robustness, consider enhancing your CI pipeline to test against both Nuxt 3 and Nuxt 4. This would provide confidence that the library works as expected on both versions and prevent future regressions.
Problem
Installing floating-vue in a Nuxt 4 project fails with peer dependency conflict:
@nuxt/kit@^4.x@nuxt/kit@^3.2.0as peer dependencyWorkaround (without this PR)
Add to your Nuxt 4 project's
package.json:The fix
Update @nuxt/kit peer dependency to accept both ^3.2.0 and ^4.0.0.
The existing implementation is already compatible with Nuxt 4