Enable a test wrongly commented out as "not working"#1224
Merged
Conversation
Akuli
added
the
skip-release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #1223 I added tests and commented out a part of them, thinking that some compiler bug prevents it from working. Turns out I just wrote the test wrong. This PR fixes and uncomments that test.
There is also another test case that I won't fix in this PR:
#global arraystring_array: byte[10][2] = ["hello", "world"] # TODO: doesn't workThe problem with this one is that string constants become pointer strings in the parser, so I would need to add another pointer string to array string conversion. Doable, but slightly more work.