fix: catch serializer errors, prevent OOM on compress error#532
Merged
fix: catch serializer errors, prevent OOM on compress error#532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes part of the issue diagnosed in zwave-js/zwave-js#8141
In essence, the custom serializer would throw an error during the auto-compression, causing the file handle to stay closed after the attempt. This would lead to the persistence thread repeating the auto-compression over and over, until the application died with an OOM error.
We now catch errors in the serializer and preserve the original value instead. Additionally if the compress task fails (e.g. due to FS permissions), we at least attempt to reopen the file.