Make ORDER a context-aware keyword #2383
Merged
+142
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ORDER was a reserved keyword in all contexts, preventing its use as table names, column names, or JSON properties. This follows the same pattern as PR #2203 for VALUE/VALUES keywords.
Changes
src/alasqlparser.jison): Added ORDER toNonReservedrule andnonReservedarraytest/test2223.js): 8 test cases covering table names, column names, JSON properties, and ORDER BY preservationExample
The parser's error recovery mechanism (
| error NonReservedin Literal rule) handles context-aware behavior automatically - ORDER remains reserved for ORDER BY syntax but accepts it as an identifier elsewhere.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.