Skip to content

fix: pr workflow not running #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 14, 2025
Merged

fix: pr workflow not running #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd13119
fix: pr workflow not running
l-qing Aug 14, 2025
2859393
chore: adjust test expectations for quicktemplate
l-qing Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,21 +31,21 @@ jobs:
# We already run the current golangci-lint in tests, but here we test
# our GitHub action with the latest stable golangci-lint.
# **Important**: The v1 version of the action on GitHub does not support golang 1.25, so it needs to be disabled.
# golangci-lint:
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v4
# - uses: actions/setup-go@v5
# with:
# # https://github.com/actions/setup-go#supported-version-syntax
# # ex:
# # - 1.18beta1 -> 1.18.0-beta.1
# # - 1.18rc1 -> 1.18.0-rc.1
# go-version: ${{ env.GO_VERSION }}
# - name: lint
# uses: golangci/[email protected]
# with:
# version: latest
golangci-lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
# https://github.com/actions/setup-go#supported-version-syntax
# ex:
# - 1.18beta1 -> 1.18.0-beta.1
# - 1.18rc1 -> 1.18.0-rc.1
go-version: ${{ env.GO_VERSION }}
# - name: lint
# uses: golangci/[email protected]
# with:
# version: latest

tests-on-windows:
needs: golangci-lint # run after golangci-lint action to not produce duplicated errors
Expand Down
2 changes: 0 additions & 2 deletions test/run_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,6 @@ func TestLineDirectiveProcessedFiles(t *testing.T) {
},
target: "quicktemplate",
expected: []string{
"testdata/quicktemplate/hello.qtpl.go:10:1: package-comments: should have a package comment (revive)",
"testdata/quicktemplate/hello.qtpl.go:26:1: exported: exported function StreamHello should have comment or be unexported (revive)",
"testdata/quicktemplate/hello.qtpl.go:39:1: exported: exported function WriteHello should have comment or be unexported (revive)",
"testdata/quicktemplate/hello.qtpl.go:50:1: exported: exported function Hello should have comment or be unexported (revive)",
Expand All @@ -290,7 +289,6 @@ func TestLineDirectiveProcessedFiles(t *testing.T) {
},
target: "quicktemplate",
expected: []string{
"testdata/quicktemplate/hello.qtpl.go:10:1: package-comments: should have a package comment (revive)",
"testdata/quicktemplate/hello.qtpl.go:26:1: exported: exported function StreamHello should have comment or be unexported (revive)",
"testdata/quicktemplate/hello.qtpl.go:39:1: exported: exported function WriteHello should have comment or be unexported (revive)",
"testdata/quicktemplate/hello.qtpl.go:50:1: exported: exported function Hello should have comment or be unexported (revive)",
Expand Down
Loading