Skip to content

Commit fa450df

Browse files
committed
Optimization: Fix display timings and improve UI aesthetics
- Config.hpp: Tune timings (40/12) and buffer (100 lines) for optimal S3 stability - page_pumps.cpp: Style sliders (PWM=Orange, Time=Blue) for better usability
1 parent 8d77e17 commit fa450df

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

display/src/core/Config.hpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,18 +38,18 @@
3838
// --- Timing Configuration (Optimized 60FPS Attempt) ---
3939
#define H_FRONT_PORCH 8
4040
#define H_PULSE_WIDTH 4
41-
#define H_BACK_PORCH 43 // Restore Golden Timing per README
41+
#define H_BACK_PORCH 20
4242
#define V_FRONT_PORCH 8
4343
#define V_PULSE_WIDTH 4
44-
#define V_BACK_PORCH 12 // Restore standard V-Porch
44+
#define V_BACK_PORCH 8
4545
#define PCLK_SPEED 16000000L // 16MHz: Smoothness attempt
4646
#define PCLK_INV 1
4747
#define BOUNCE_BUFFER_SIZE (SCREEN_WIDTH * 20) // Keep buffer size conservative
4848

4949
// --- LVGL Configuration ---
5050
#define SCREEN_WIDTH 800
5151
#define SCREEN_HEIGHT 480
52-
#define LVGL_DRAW_LINES 40 // Use 40 lines to fit in internal RAM
52+
#define LVGL_DRAW_LINES 100 // Reduced to 20 to free SRAM and avoid bus contention
5353
#define DOUBLE_BUFFER_ENABLED 1
5454
// Disabled to avoid reboot loop
5555

display/src/ui/pages/page_pumps.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ static void create_pump_card(lv_obj_t * parent, const char * name, int* pwm_ptr,
142142
pwm_data->is_time = false;
143143

144144
lv_obj_t * pwm_slider = create_custom_slider(card, 0, 255, LV_PCT(100), NULL);
145+
lv_obj_set_style_bg_color(pwm_slider, lv_palette_main(LV_PALETTE_ORANGE), LV_PART_INDICATOR); // Orange for PWM
145146
lv_slider_set_value(pwm_slider, *pwm_ptr, LV_ANIM_OFF);
146147
lv_obj_add_event_cb(pwm_slider, pump_slider_event_cb, LV_EVENT_VALUE_CHANGED, pwm_data);
147148
lv_obj_add_event_cb(pwm_slider, pump_slider_event_cb, LV_EVENT_RELEASED, pwm_data);
@@ -175,6 +176,7 @@ static void create_pump_card(lv_obj_t * parent, const char * name, int* pwm_ptr,
175176
time_data->is_time = true;
176177

177178
lv_obj_t * time_slider = create_custom_slider(card, 500, 10000, LV_PCT(100), NULL);
179+
lv_obj_set_style_bg_color(time_slider, lv_palette_main(LV_PALETTE_BLUE), LV_PART_INDICATOR); // Blue for Time
178180
lv_slider_set_value(time_slider, *time_ptr, LV_ANIM_OFF);
179181
lv_obj_add_event_cb(time_slider, pump_slider_event_cb, LV_EVENT_VALUE_CHANGED, time_data);
180182
lv_obj_add_event_cb(time_slider, pump_slider_event_cb, LV_EVENT_RELEASED, time_data);

0 commit comments

Comments
 (0)