Conversation
…e image as usual and when a new image is available it show the new image automatically. i change the transparecy too and reduce the slidecaption height
|
Thanks @davidea72 . @mpbraendli Can you have a look, please? |
|
Thanks for the PR, I've written some comments for you. Sorry for the delay, if you're not interested in this anymore, let me know. |
|
please led me to the comment, i can't find it. |
|
The comments are in-line, inside the github user interface. |
|
i know i can seem to be a newbie, but i can't find the comments , are they public? |
|
I cannot find @mpbraendli 's comments neither. |
|
|
||
| s["dls"] = ""; | ||
|
|
||
| global_service_mot_time=service.mot.time; |
There was a problem hiding this comment.
what is this global_service_mot_time?
| s["dls"] = ""; | ||
|
|
||
| global_service_mot_time=service.mot.time; | ||
| if (service.mot.time>show && show ) { |
There was a problem hiding this comment.
Please indent the code with four spaces, not tabs
| slidecaption.innerHTML = last_update; | ||
| slide_modal.style.display = "block"; | ||
| show=last_update_time; | ||
| console.log(slideimg.src) |
There was a problem hiding this comment.
Please remove the console.log
|
|
||
| function setPlayerSource(sid) { | ||
| document.getElementById("player").src = "/stream/" + sid; | ||
| document.getElementById("player").src = "/mp3/" + sid; |
|
|
||
| var png_chevron_down = "iVBORw0KGgoAAAANSUhEUgAAABgAAAAYCAYAAADgdz34AAAABHNCSVQICAgIfAhkiAAAAAlwSFlzAAAOxAAADsQBlSsOGwAAABl0RVh0U29mdHdhcmUAd3d3Lmlua3NjYXBlLm9yZ5vuPBoAAAB0SURBVEiJ7Y87CoAwEAVHD2khqIUgCF5HUPBzUL9NgiGoSKKN7MAW4cEMAUEQnlAAycUWA6WPPAcWdZm1RcAErEDlGmiATd3M8ZNYvfXWuQYCoLUijSXvgdA1oCO1ITRv8JXfRV6Tn0XGt+VmJP1KLgh/ZQd6AiOdJgUioQAAAABJRU5ErkJggg==" | ||
|
|
||
| var show=0; |
There was a problem hiding this comment.
Please give a more meaningful name to that variable
|
Do you see them now? They were marked 'pending', maybe that's why they were visible only to me. Sorry about that. |
|
Yes, now it's public. |
|
Please see above comments. Your Pull Request is still open. |
4 participants
change the behaviour of the SLS, it was static
now when you click on SLS it show the image as usual and when a new image is available it show the new image automatically.
i change the transparecy too and reduce the slidecaption height
to test it, just run welle-cli and tune to a station with sls, when it's received click on it and wait for the new image