-
Notifications
You must be signed in to change notification settings - Fork 40
Use Alchemy::Configuration for config #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Alchemy 8 changed how to stub the config from positional arguments to a hash
In latest Rack unprocessable_entity is deprecated
Instead of our own config we make use of the new `Alchemy::Configuration` introduced in Alchemy 8.0, which gives better DX. All exising config setters and getters are still working, but are deprecated.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
==========================================
+ Coverage 98.55% 98.62% +0.07%
==========================================
Files 10 11 +1
Lines 276 291 +15
==========================================
+ Hits 272 287 +15
Misses 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Oh, we need to back port the symbol option into Alchemy 8.0 |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
[8.0-stable] Merge pull request #236 from AlchemyCMS/alchemy-config
Instead of our own config we make use of the
new
Alchemy::Configurationintroduced inAlchemy 8.0, which gives better DX.
All exising config setters and getters are still
working, but are deprecated.