Skip to content

Conversation

@tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Nov 28, 2025

Instead of our own config we make use of the
new Alchemy::Configuration introduced in
Alchemy 8.0, which gives better DX.

All exising config setters and getters are still
working, but are deprecated.

Alchemy 8 changed how to stub the config from
positional arguments to a hash
In latest Rack unprocessable_entity is deprecated
Instead of our own config we make use of the
new `Alchemy::Configuration` introduced in
Alchemy 8.0, which gives better DX.

All exising config setters and getters are still
working, but are deprecated.
@tvdeyen tvdeyen added this to the 8.0 milestone Nov 28, 2025
@tvdeyen tvdeyen requested a review from mamhoff November 28, 2025 08:57
@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

❌ Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 98.62%. Comparing base (8a1be05) to head (7c1e67a).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
lib/alchemy/devise.rb 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
+ Coverage   98.55%   98.62%   +0.07%     
==========================================
  Files          10       11       +1     
  Lines         276      291      +15     
==========================================
+ Hits          272      287      +15     
  Misses          4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen
Copy link
Member Author

tvdeyen commented Nov 28, 2025

Oh, we need to back port the symbol option into Alchemy 8.0

@tvdeyen tvdeyen merged commit c00dc42 into main Nov 28, 2025
59 of 78 checks passed
@tvdeyen tvdeyen deleted the alchemy-config branch November 28, 2025 09:11
@tvdeyen tvdeyen added the backport-to-8.0-stable Needs a back port to 8.0-stable label Dec 4, 2025
@alchemycms-bot
Copy link

alchemycms-bot bot commented Dec 4, 2025

💚 All backports created successfully

Status Branch Result
8.0-stable

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

tvdeyen added a commit that referenced this pull request Dec 4, 2025
[8.0-stable] Merge pull request #236 from AlchemyCMS/alchemy-config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-8.0-stable Needs a back port to 8.0-stable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants