Skip to content

Conversation

@tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Dec 9, 2025

What is this pull request for?

If the preview frame fails to load after 5 seconds we show a error message and re-enable the reload button, so the user can try again.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

If the preview frame fails to load after 5 seconds we show a
error message and re-enable the reload button, so the user
can try again.

Signed-off-by: Thomas von Deyen <[email protected]>
@tvdeyen tvdeyen added this to the 8.1 milestone Dec 9, 2025
@tvdeyen tvdeyen requested a review from a team as a code owner December 9, 2025 14:15
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.19%. Comparing base (0cf82ef) to head (b50076b).
⚠️ Report is 44 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3508   +/-   ##
=======================================
  Coverage   97.19%   97.19%           
=======================================
  Files         287      287           
  Lines        7558     7558           
=======================================
  Hits         7346     7346           
  Misses        212      212           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen tvdeyen merged commit 6fa7be4 into main Dec 9, 2025
17 checks passed
@tvdeyen tvdeyen deleted the preview-window-retry branch December 9, 2025 15:14
@tvdeyen tvdeyen added the backport-to-8.0-stable Needs to be backported to 8.0-stable label Dec 20, 2025
@alchemycms-bot
Copy link

💚 All backports created successfully

Status Branch Result
8.0-stable

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-8.0-stable Needs to be backported to 8.0-stable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants