Skip to content

[8.0-stable] fix(page filter): Only select from content pages #3519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tvdeyen merged 1 commit into from
Dec 15, 2025
Merged

[8.0-stable] fix(page filter): Only select from content pages #3519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/controllers/alchemy/admin/pages_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@ class PagesController < ResourcesController
only: [:show]

add_alchemy_filter :by_page_layout, type: :select, options: ->(_q) do
PageDefinition.all.map { |p| [Alchemy.t(p[:name], scope: "page_layout_names"), p[:name]] }
PageDefinition.all.reject(&:layoutpage).tap do |page_layouts|
page_layouts.map! { |p| [Alchemy.t(p[:name], scope: "page_layout_names"), p[:name]] }
end
end

add_alchemy_filter :updated_at_gteq, type: :datepicker
Expand Down
8 changes: 8 additions & 0 deletions spec/features/admin/page_list_feature_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,5 +116,13 @@
expect(page).to_not have_css("tr:nth-child(3)")
end
end

specify "page type filter only includes content pages" do
visit admin_pages_path(view: "list")
options = find_all("select#q_by_page_layout > option")
options.each do |option|
expect(option.value).to_not eq("footer")
end
end
end
end