Skip to content

Conversation

@tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Dec 17, 2025

What is this pull request for?

It is this time of the year where I spent some time to fix lots of small UI glitches that have summed up over
the time. Visually broken software feels cheap and broken, so we need to polish from time to time.

  1. Fix element header icons sizes and spaces
    On narrow screens with compact elements we weren't able
    to see the element icon properly.

  2. Fix video attachment window size
    We need it to be as wide as the other attachments
    in order for the file info text disaply to work.

  3. Fix file ingredient vertical alignment
    The icons and text where vertically off.

  4. Fix headline ingredient select focus style

  5. Fix locked page tab vertical alignment

  6. fix(resource-info): Allow multiline values
    We changed that to fix an issue with long
    attachment names, but we also use this
    at the page info dialog, where we need
    a multiline value.

  7. fix(locked pages): Make horizontally scrollable
    For many locked pages we want to be able to
    scroll and not wrap the text weirdly.

  8. Highlight user info
    This is not part of the locked pages section
    and a interactive menu like interface. It should
    be visually part of the toolbar.

  9. Do not truncate locked page name
    The container is scrollable now and we want
    to see the full page name.

  10. Hide user info on small screens
    We can use the precious screen space
    for more useful information, like
    locked pages.

  11. feat(user info): Show icon
    Use an icon instead of a long sentence
    saves some precious screen space and
    is widely adopted.

@tvdeyen tvdeyen requested a review from a team as a code owner December 17, 2025 17:22
@tvdeyen tvdeyen added bug backport-to-8.0-stable Needs to be backported to 8.0-stable labels Dec 17, 2025
@codecov
Copy link

codecov bot commented Dec 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.20%. Comparing base (e47d0e0) to head (826ca9b).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3524   +/-   ##
=======================================
  Coverage   97.20%   97.20%           
=======================================
  Files         287      287           
  Lines        7586     7587    +1     
=======================================
+ Hits         7374     7375    +1     
  Misses        212      212           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen tvdeyen force-pushed the fix-element-header branch 2 times, most recently from ea38a5f to f441491 Compare December 18, 2025 13:36
@tvdeyen tvdeyen changed the title Fix element header icons sizes and spaces Fix CSS glitches Dec 18, 2025
@tvdeyen tvdeyen force-pushed the fix-element-header branch 2 times, most recently from 83f9fc4 to 7878fce Compare December 19, 2025 15:29
On narrow screens with compact elements we weren't able
to see the element icon properly.

Signed-off-by: Thomas von Deyen <[email protected]>
@tvdeyen tvdeyen force-pushed the fix-element-header branch 2 times, most recently from 428073b to f77b473 Compare December 19, 2025 15:39
@tvdeyen tvdeyen changed the title Fix CSS glitches Fix UI glitches 2025 Dec 19, 2025
We need it to be as wide as the other attachments
in order for the file info text disaply to work.

Signed-off-by: Thomas von Deyen <[email protected]>
The icons and text where vertically off.

Signed-off-by: Thomas von Deyen <[email protected]>
Again...

Signed-off-by: Thomas von Deyen <[email protected]>
We changed that to fix an issue with long attachment
names, but we also use this at the page info dialog,
where we need a multiline value.

Signed-off-by: Thomas von Deyen <[email protected]>
For many locked pages we want to be able to
scroll and not wrap the text weirdly.
This is not part of the locked pages section
and a interactive menu like interface. It should
be visually part of the toolbar.
The container is scrollable now and we want
to see the full page name.

Signed-off-by: Thomas von Deyen <[email protected]>
We can use the precious screen space
for more useful information, like
locked pages.
Use an icon instead of a long sentence
saves some precious screen space and
is widely adopted.
@tvdeyen tvdeyen merged commit 89ae8ab into main Dec 22, 2025
18 checks passed
@tvdeyen tvdeyen deleted the fix-element-header branch December 22, 2025 07:46
@alchemycms-bot
Copy link

💔 All backports failed

Status Branch Result
8.0-stable Backport failed because of merge conflicts

You might need to backport the following PRs to 8.0-stable:
- Remove dialog sitemap css code
- Fix sitemap highlight color in dark mode
- Make create element dialog wider (#3445)
- Fix element icon hover for elements with warning (#3444)
- Fix select2 close icon visibility (#3443)

Manual backport

To create the backport manually run:

backport --pr 3524

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@alchemycms-ci-bot
Copy link
Collaborator

💚 All backports created successfully

Status Branch Result
8.0-stable

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-8.0-stable Needs to be backported to 8.0-stable bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants