-
-
Notifications
You must be signed in to change notification settings - Fork 317
Fix UI glitches 2025 #3524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UI glitches 2025 #3524
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3524 +/- ##
=======================================
Coverage 97.20% 97.20%
=======================================
Files 287 287
Lines 7586 7587 +1
=======================================
+ Hits 7374 7375 +1
Misses 212 212 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ea38a5f to
f441491
Compare
83f9fc4 to
7878fce
Compare
On narrow screens with compact elements we weren't able to see the element icon properly. Signed-off-by: Thomas von Deyen <[email protected]>
428073b to
f77b473
Compare
We need it to be as wide as the other attachments in order for the file info text disaply to work. Signed-off-by: Thomas von Deyen <[email protected]>
The icons and text where vertically off. Signed-off-by: Thomas von Deyen <[email protected]>
Signed-off-by: Thomas von Deyen <[email protected]>
Again... Signed-off-by: Thomas von Deyen <[email protected]>
We changed that to fix an issue with long attachment names, but we also use this at the page info dialog, where we need a multiline value. Signed-off-by: Thomas von Deyen <[email protected]>
f77b473 to
aa81a6f
Compare
For many locked pages we want to be able to scroll and not wrap the text weirdly.
This is not part of the locked pages section and a interactive menu like interface. It should be visually part of the toolbar.
The container is scrollable now and we want to see the full page name. Signed-off-by: Thomas von Deyen <[email protected]>
We can use the precious screen space for more useful information, like locked pages.
Use an icon instead of a long sentence saves some precious screen space and is widely adopted.
aa81a6f to
826ca9b
Compare
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
What is this pull request for?
It is this time of the year where I spent some time to fix lots of small UI glitches that have summed up over
the time. Visually broken software feels cheap and broken, so we need to polish from time to time.
Fix element header icons sizes and spaces
On narrow screens with compact elements we weren't able
to see the element icon properly.
Fix video attachment window size
We need it to be as wide as the other attachments
in order for the file info text disaply to work.
Fix file ingredient vertical alignment
The icons and text where vertically off.
Fix headline ingredient select focus style
Fix locked page tab vertical alignment
fix(resource-info): Allow multiline values
We changed that to fix an issue with long
attachment names, but we also use this
at the page info dialog, where we need
a multiline value.
fix(locked pages): Make horizontally scrollable
For many locked pages we want to be able to
scroll and not wrap the text weirdly.
Highlight user info
This is not part of the locked pages section
and a interactive menu like interface. It should
be visually part of the toolbar.
Do not truncate locked page name
The container is scrollable now and we want
to see the full page name.
Hide user info on small screens
We can use the precious screen space
for more useful information, like
locked pages.
feat(user info): Show icon
Use an icon instead of a long sentence
saves some precious screen space and
is widely adopted.