[8.0-stable] Fix filtering Attachments by only or except setting #3525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has been broken for a long time now. Signed-off-by: Thomas von Deyen <[email protected]> (cherry picked from commit 83d04dd)
Signed-off-by: Thomas von Deyen <[email protected]> (cherry picked from commit 3a4e5ec)
Otherwise it will first be full width and wraps to a new line. Since seletc2 calculates the width this makes sure the input stays on the same line. Signed-off-by: Thomas von Deyen <[email protected]> (cherry picked from commit df74847) # Conflicts: # app/assets/builds/alchemy/admin.css
Very useful to allow multiple values to be selected for the same filter (ie. file types) Signed-off-by: Thomas von Deyen <[email protected]> (cherry picked from commit c063862)
If we want to be able to remove an option from the multiple select we need to allow it to clear. Signed-off-by: Thomas von Deyen <[email protected]> (cherry picked from commit 3ac1aaa)
We want to be able to load file types by extension instead of the full mime type for the File ingredient only and except feature. Signed-off-by: Thomas von Deyen <[email protected]> (cherry picked from commit 1f2a33b)
If allowed file extensions are set via the only param, we restrict the available file types to select from to that collection, making sure users cannot attach other files than the allowed ones. Signed-off-by: Thomas von Deyen <[email protected]> (cherry picked from commit 0a53d90) # Conflicts: # app/views/alchemy/admin/partials/_remote_search_form.html.erb
Instead of just the tag list, we make the whole sidebar scrollable, if it exceeds the vertical space left. Makes it much better usable for varying filter counts and heights. Signed-off-by: Thomas von Deyen <[email protected]> (cherry picked from commit 6dda466) # Conflicts: # app/assets/builds/alchemy/admin.css
Signed-off-by: Thomas von Deyen <[email protected]> (cherry picked from commit 7f71821) # Conflicts: # app/assets/builds/alchemy/admin.css # app/assets/builds/alchemy/dark-theme.css # app/assets/builds/alchemy/light-theme.css # app/assets/builds/alchemy/theme.css
3 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.0-stable #3525 +/- ##
==============================================
+ Coverage 97.18% 97.19% +0.01%
==============================================
Files 287 287
Lines 7521 7548 +27
==============================================
+ Hits 7309 7336 +27
Misses 212 212 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.0-stable:Questions ?
Please refer to the Backport tool documentation