Fix overlay uploader #3526
Merged
Fix overlay uploader #3526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The archive overlay is handled by a turbo-frame. We need to reload that frame instead of using the old jQuery based weird script loading. Signed-off-by: Thomas von Deyen <[email protected]>
When passing `only` from the ingredient that opens the uploader, we scope the files to that accepted formats only. Signed-off-by: Thomas von Deyen <[email protected]>
Signed-off-by: Thomas von Deyen <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3526 +/- ##
=======================================
Coverage 97.20% 97.20%
=======================================
Files 287 287
Lines 7586 7586
=======================================
Hits 7374 7374
Misses 212 212 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sascha-karnatz
approved these changes
Dec 19, 2025
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Collaborator
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
The archive overlay is handled by a turbo-frame. We need to reload that frame instead of using the old jQuery based weird script loading.
When passing
onlyfrom the ingredient that opens the uploader, we scope the files to that accepted formats only.Fix the Attachment replace button so it respects the
allowed_filetypesconfiguration.Checklist