fix(PictureDescriptionSelect): Add site name to identify language #3530
+199
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The language select in picture descriptions should be a testable component. Signed-off-by: Thomas von Deyen <[email protected]>
Instead of an inline script tag we use a custom element that handles the internal event handling much more reliable. Signed-off-by: Thomas von Deyen <[email protected]>
In a multi site environment, the languages have the same code. Adding the site name helps to identify the language per site. Signed-off-by: Thomas von Deyen <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3530 +/- ##
=======================================
Coverage 97.20% 97.21%
=======================================
Files 287 288 +1
Lines 7587 7608 +21
=======================================
+ Hits 7375 7396 +21
Misses 212 212 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Collaborator
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
In a multi site environment, the languages have the
same code. Adding the site name helps to identify the
language per site.
Notable changes
Add a custom element and a view component to encapsulate behaviour and make it testable.
Checklist