Skip to content

[8.0-stable] Fix missing callback in page_controller #3544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tvdeyen merged 2 commits into from
Dec 29, 2025
Merged

[8.0-stable] Fix missing callback in page_controller #3544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
195e7d5
Enable raise_on_missing_callback_actions config
sascha-karnatz Dec 26, 2025
2ec527e
Remove callbacks for tree action in page_controller
sascha-karnatz Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/controllers/alchemy/admin/pages_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ class PagesController < ResourcesController

before_action :load_resource, except: [:index, :flush, :new, :create, :copy_language_tree, :link]

authorize_resource class: Alchemy::Page, except: [:index, :tree]
authorize_resource class: Alchemy::Page, except: [:index]

before_action only: [:index, :tree, :flush, :new, :create, :copy_language_tree] do
before_action only: [:index, :flush, :new, :create, :copy_language_tree] do
authorize! :index, :alchemy_admin_pages
end

Expand Down
3 changes: 3 additions & 0 deletions spec/dummy/config/environments/development.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@
config.cache_store = :null_store
end

# Raise error when a before_action's only/except options reference missing actions.
config.action_controller.raise_on_missing_callback_actions = true

# Don't care if the mailer can't send.
config.action_mailer.raise_delivery_errors = false

Expand Down
3 changes: 3 additions & 0 deletions spec/dummy/config/environments/test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@
# Disable request forgery protection in test environment.
config.action_controller.allow_forgery_protection = true

# Raise error when a before_action's only/except options reference missing actions.
config.action_controller.raise_on_missing_callback_actions = true

config.action_mailer.perform_caching = false

# Tell Action Mailer not to deliver emails to the real world.
Expand Down