feat: Move page metadata to PageVersion #3554
Merged
+583
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mamhoff
approved these changes
Jan 5, 2026
Contributor
mamhoff
left a comment
mamhoff
left a comment
There was a problem hiding this comment.
A few comments here. Otherwise moving metadata to versions is great!
tvdeyen
force-pushed
the
move-page-meta-data-to-page-version
branch
from
067b570 to
7489441
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3554 +/- ##
==========================================
+ Coverage 97.25% 97.26% +0.01%
==========================================
Files 291 291
Lines 7682 7721 +39
==========================================
+ Hits 7471 7510 +39
Misses 211 211 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tvdeyen
force-pushed
the
move-page-meta-data-to-page-version
branch
7 times, most recently
from
797a5e0 to
8a58ac5
Compare
Replace the top-level Upgrader constant with Alchemy::Upgrader[version] class method (similar to ActiveRecord::Migration[version]). This avoids constant redefinition warnings when the rake file is loaded multiple times, while still ensuring todos are accumulated across rake tasks via memoization.
Add title, meta_description, and meta_keywords to alchemy_page_versions table. This prepares for versioned page metadata where each version (draft/public) maintains its own content metadata.
Page metadata (title, meta_description, meta_keywords) is now stored on PageVersion, enabling different content for draft and published versions. The Page model delegates these attributes to public_version for backward compatibility. Admin forms write to draft_version, and publishing copies metadata from draft to the new public version.
Provides a rake task to copy existing page metadata (title, meta_description, meta_keywords) to all page versions during upgrade.
In other tests we add todos and this is a cached singleton attribute.
tvdeyen
force-pushed
the
move-page-meta-data-to-page-version
branch
from
8a58ac5 to
7e01082
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Page metadata (
title,meta_description,meta_keywords) is now stored onPageVersion, enabling different content for draft and published versions.The Page model delegates these attributes to
public_versionfor backwardcompatibility. Admin forms write to
draft_version, and publishing copiesmetadata from draft to the new public version.
Provides a rake task to copy existing page metadata to all page versions during upgrade.
Notable changes
Deprecates setting
title=,meta_description=andmeta_keywords=on page.Checklist