Fix deprecated ingredient editors #3556
Merged
+14
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecated ingredient editor partials need a IngredientEditor decorator instance Signed-off-by: Thomas von Deyen <[email protected]>
The IngredientEditor decorator is deprecated. Since we already log a deprecation warning while rendering the editor partial, we must not log any additional warnings. Signed-off-by: Thomas von Deyen <[email protected]>
As private method rails logs this as been called by the call method and not the element editor, where it actually comes from. Signed-off-by: Thomas von Deyen <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3556 +/- ##
==========================================
- Coverage 97.35% 97.35% -0.01%
==========================================
Files 308 308
Lines 8011 8010 -1
==========================================
- Hits 7799 7798 -1
Misses 212 212 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sascha-karnatz
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Fixes a bug where a deprecated ingredient editor partial raises an error
about missing methods that provided by the IngredientEditor decorator.
Checklist