feat: Add schedule element button #3621
Open
+1,742
−1,444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
element-visibility-button
branch
6 times, most recently
from
c97a425 to
f739f8e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3621 +/- ##
==========================================
+ Coverage 97.48% 97.50% +0.01%
==========================================
Files 314 315 +1
Lines 8286 8332 +46
==========================================
+ Hits 8078 8124 +46
Misses 208 208 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tvdeyen
force-pushed
the
element-visibility-button
branch
from
f739f8e to
9a59052
Compare
Signed-off-by: Thomas von Deyen <vondeyen@blish.cloud>
If you want to have two buttons aligned under the input fields of a form use the `.buttons` container class
The hidden property hides an element from the screen, but since the display property has precedence we also need to force hide it visually.
Allows to programmatically clear flatpickr
tvdeyen
force-pushed
the
element-visibility-button
branch
8 times, most recently
from
601a4be to
cc94e59
Compare
tvdeyen
force-pushed
the
element-visibility-button
branch
from
cc94e59 to
b7503f2
Compare
tvdeyen
force-pushed
the
element-visibility-button
branch
2 times, most recently
from
ce22641 to
fefd7c5
Compare
tvdeyen
force-pushed
the
element-visibility-button
branch
from
fefd7c5 to
69008b5
Compare
Easier to test time based publishing that way
Replaces the public toggle with a split button which allows to schedule the element for publication.
No need to query the length here. Thanks rubocop
tvdeyen
force-pushed
the
element-visibility-button
branch
from
69008b5 to
e22b73b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Make the recently introduced
public_onandpublic_untilfields of elements usable by introducing UI to schedule element visibility.Notable changes
Replaces the publish toggle with a split button which allows to schedule the element for publication.
Screenshots
Checklist