Skip to content

fix(color-select): Do not prefill color picker value on init#3629

Merged
tvdeyen merged 1 commit intomainfrom
do-not-prefill-color-value
Feb 4, 2026
Merged

fix(color-select): Do not prefill color picker value on init#3629
tvdeyen merged 1 commit intomainfrom
do-not-prefill-color-value

Conversation

@tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Feb 4, 2026

What is this pull request for?

For single color inputs without a set of colors we want to be able to remove the color.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen added this to the 8.1 milestone Feb 4, 2026
@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.48%. Comparing base (8146559) to head (cdd54c7).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3629   +/-   ##
=======================================
  Coverage   97.48%   97.48%           
=======================================
  Files         314      314           
  Lines        8269     8270    +1     
=======================================
+ Hits         8061     8062    +1     
  Misses        208      208           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen tvdeyen self-assigned this Feb 4, 2026
Sometimes we do not want to save a color, because it is optional.
@tvdeyen tvdeyen force-pushed the do-not-prefill-color-value branch from f4126a1 to cdd54c7 Compare February 4, 2026 10:46
@tvdeyen tvdeyen marked this pull request as ready for review February 4, 2026 10:46
@tvdeyen tvdeyen requested a review from a team as a code owner February 4, 2026 10:46
@tvdeyen tvdeyen removed their assignment Feb 4, 2026
@tvdeyen tvdeyen enabled auto-merge February 4, 2026 10:47
@tvdeyen tvdeyen merged commit 2fdb4d0 into main Feb 4, 2026
20 checks passed
@tvdeyen tvdeyen deleted the do-not-prefill-color-value branch February 4, 2026 10:54
@tvdeyen tvdeyen added the backport-to-8.1-stable Needs to be backported to 8.1-stable label Feb 4, 2026
@alchemycms-bot
Copy link

alchemycms-bot bot commented Feb 4, 2026

💚 All backports created successfully

Status Branch Result
8.1-stable

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-8.1-stable Needs to be backported to 8.1-stable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants