[8.1-stable] fix(elements-window): Use fixed position #3644
+15
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`position: absolute` can lead to weird scrolling offsets in some situations. With `display: fixed` we make sure it stays on the same fixed position on the screen, regardless of the scroll position. While fixing that I fugred that the transition animation from preview window and elements window were not the same. (cherry picked from commit b06b75b)
The elements window was offscreen by default and only visible on the edit page screen. Since automated browser testing tools (capybara with selenium) open the elements index view the elements window was always offscreen and the browser needed to scroll the window into view. With the recent change from absolute to fixed position this was not working anymore. Co-authored-by: Lasse Diercks <github@lassediercks.de> (cherry picked from commit ec563dd)
2 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 8.1-stable #3644 +/- ##
===========================================
Coverage 97.48% 97.48%
===========================================
Files 314 314
Lines 8272 8272
===========================================
Hits 8064 8064
Misses 208 208 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tvdeyen
approved these changes
Feb 5, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.1-stable:Questions ?
Please refer to the Backport tool documentation