Set public_until instead of clearing public_on when unpublishing elements#3675
Merged
Set public_until instead of clearing public_on when unpublishing elements#3675
public_until instead of clearing public_on when unpublishing elements#3675Conversation
…ents Previously, setting `public = false` on an element cleared its `public_on` timestamp, turning it into a draft. Now it sets `public_until` to the current time, preserving the publication history while marking the element as expired. Setting `public = true` now also always refreshes `public_on` and clears any `public_until` value.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3675 +/- ##
=======================================
Coverage 97.48% 97.48%
=======================================
Files 314 314
Lines 8285 8286 +1
=======================================
+ Hits 8077 8078 +1
Misses 208 208 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notable changes
Previously, setting
public = falseon an element cleared itspublic_ontimestamp, turning it into a draft. Now it setspublic_untilto the current time, preserving the publication history while marking the element as expired. Settingpublic = truenow also always refreshespublic_onand clears anypublic_untilvalue.Checklist