-
Notifications
You must be signed in to change notification settings - Fork 4
Refactor: Make swift concurrency core implementation - RequestPerformable #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Aldo10012
merged 18 commits into
main
from
REFACTOR_make_Swift_Concurrency_CORE_implementation___RequestPerformable
Feb 3, 2026
Merged
Refactor: Make swift concurrency core implementation - RequestPerformable #89
Aldo10012
merged 18 commits into
main
from
REFACTOR_make_Swift_Concurrency_CORE_implementation___RequestPerformable
Feb 3, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endency to help with tests
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the reason for this PR?
Inside of the different request performing class, we support:
To prevent writing duplicate code, the completion handler method was used as the CORE implementation, and Swift concurrency and combine methods are wrappers of the completion handler method.
Apple recommends that any new async code should be written in Swift Concurrency.
What's new?
This PR focuses on RequestPerformable. Other classes will be refactored in follow up PRs.
.performTask(...)return type fromURLSessionDataTasktoCancellableRequest