Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Nov 27, 2024

Description

No description.

Before Merging

  • Review the code changes
    • Unused print / comments / TODOs
    • Missing docstrings for functions that should have them
    • Consistent variable names
    • ...
  • Update changelog.md if necessary
  • Commit messages should contain a semantic label and the ticket number
    • Consider squashing if this is not the case

@ghost ghost force-pushed the di-190-retrieve-chunks branch 2 times, most recently from a5d506c to ce0dd52 Compare November 29, 2024 08:10
Copy link
Contributor

@SebastianNiehusAA SebastianNiehusAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clean. It would be great if you could also add a small block about this to the document_index.ipynb

@ghost ghost force-pushed the di-190-retrieve-chunks branch from ce0dd52 to 874d0c2 Compare December 2, 2024 10:41
@ghost ghost requested a review from SebastianNiehusAA December 16, 2024 14:37
@SebastianNiehusAA SebastianNiehusAA merged commit 08331e1 into main Dec 16, 2024
4 checks passed
@SebastianNiehusAA SebastianNiehusAA deleted the di-190-retrieve-chunks branch December 16, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants