Skip to content

Fix optional fields generic#478

Open
gustavo-shigueo wants to merge 3 commits intomainfrom
fix_optional_fields_generic
Open

Fix optional fields generic#478
gustavo-shigueo wants to merge 3 commits intomainfrom
fix_optional_fields_generic

Conversation

@gustavo-shigueo
Copy link
Collaborator

Goal

Fix missing trait bound for TS::OptionInnerType
Closes #476

Changes

Added TS trait bound to OptionInnerType

Checklist

  • I have followed the steps listed in the Contributing guide.
  • If necessary, I have added documentation related to the changes made.
  • I have added or updated the tests related to the changes made.

@NyxCode
Copy link
Collaborator

NyxCode commented Feb 11, 2026

Nice, I guess that'll do it!
I guess this is TECHNICALLY breaking, right? I doubt it'd break anyone, so idk if we should care..

@gustavo-shigueo
Copy link
Collaborator Author

I guess this is TECHNICALLY breaking, right? I doubt it'd break anyone, so idk if we should care..

Yeah, it's one of those lol, but since we always set OptionInnerType to Self for anything that isn't Option<T> (and advise manual implementations to do the same), it shouldn't matter at all, as Self is, by definition, an implementer of TS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: ts(optional_fields) does not compile with generic parameters

2 participants