Change the DB interface to allow multiple implementations of the modules. Personality Interface.#1250
Closed
caneppelevitor wants to merge 8 commits intostagefrom
Closed
Change the DB interface to allow multiple implementations of the modules. Personality Interface.#1250caneppelevitor wants to merge 8 commits intostagefrom
caneppelevitor wants to merge 8 commits intostagefrom
Conversation
- Adapted the app module to accept multi-DB logic - Created a new config variable and config file to set up DB type - Adapted personality files to support multi-DB - Created a personality provider to manage service selection - Created interfaces (personality and service) using Zod - Created a mongo folder to hold files for MongoDB logic - Fixed a spelling error in "skipped"
thesocialdev
changed the title
thesocialdev
requested changes
Jun 13, 2024
- Removed unused env variable - Removed ConfigModule and ThrottlerModule from if - Exported in the declaration of interfaces - Properly organized personality module - Removed forgotten test lines on personality service - Removed duplication on stats service - Removed TODOS
|
caneppelevitor
changed the title
thesocialdev
force-pushed
the
stage
branch
7 times, most recently
from
0ae3b52 to
20bbdca
Compare
thesocialdev
force-pushed
the
stage
branch
6 times, most recently
from
05f8912 to
864c35e
Compare
|
Collaborator
|
@caneppelevitor one last rebase/merge and I'll merge it! |
Collaborator
Author
This branch was cherry-picked into another branch and merged. I think we can delete this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.