Merged
Conversation
Collaborator
Author
|
There was a style change that came by default with the library. I can replicate the old style if necessary. Is it necessary? |
LuizFNJ
requested review from
Keikonichi,
Toxin4,
caneppelevitor,
lucaslobatob and
pepermao
LuizFNJ
force-pushed
the
Change-all-popover-and-tooltip
branch
from
6e4e7d7 to
fd01b85
Compare
|
Collaborator
|
With the transition to MUI, we will have some slight UI changes that are not a problem. We should not try to match every style Antd have. |
thesocialdev
approved these changes
Jan 15, 2025
LuizFNJ
changed the title
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I replaced all the avatars, tooltips, and popovers from Ant Design to MUI. I also replaced some Col, Row, Divider, and Typography components that were together and hadn’t been replaced yet.
Where the Ant Design popover was used on the platform solely to display informational messages without user interaction, and which was triggered on hover, I decided to use the MUI Material tooltip, defining two types within this component (a styled one and a standard one). When calling the component, the developer can specify which one to use in the props.
Where the popover with user interaction was used and triggered by a click, I replaced it with the MUI Material popover, implementing the functionality manually. I grouped this into a component to be reused wherever necessary.
The SentencePopover component no longer exists, and its functionality has been moved to ClaimSentence, where it was originally called, but now using InfoTooltip.tsx.
Does it make sense?
Testing
To test the tooltip components, you should hover the mouse over the child component and check if the message appears. The popover should be triggered by a user click. Avatars, Col, Row, Divider, and Typography should be tested more for the visual aspect. I’m creating a document with screenshots to make the testing process easier.
components:
A visual document outlining which visual parts of the site are intended to facilitate testing:
teste popover e tooltips.pdf
closes #1502 closes #1529 closes #1539 closes #1555 closes #1563 closes #1564 closes #1569 closes #1638 closes #1667 closes #1695 closes #1696 closes #1697 closes #1698 closes #1699 closes #1700 closes #1701 closes #1702 closes #1703 closes #1707