Skip to content

Migration from Radio to MUI ButtonGroup#1772

Closed
lucaslobatob wants to merge 7 commits intostagefrom
1525-migrate-radio
Closed

Migration from Radio to MUI ButtonGroup#1772
lucaslobatob wants to merge 7 commits intostagefrom
1525-migrate-radio

Conversation

@lucaslobatob
Copy link
Collaborator

Description

ToggleSection.tsx: Changed the RadioGroup to ButtonGroup and styled with Styled Components for better personification on the ClaimView page.
ClaimView.tsx: Updated onChange behavior, the onChange logic has been maintained so that it works with ButtonGroup buttons, adapting the click event to correctly reflect the state.

Fixes #1525

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Existing feature enhancement (non-breaking change which modifies existing functionality)

Testing

1. Be logged into the platform;
2. Enter a personality;
3. Open a Claim for a personality who already has speeches evaluated;
4. Test the "Mostrar Destaques" and "Ocultar Destaques" button

Before:
Screenshot from 2025-01-06 13-04-56

After:
Screenshot from 2025-01-16 14-23-59

Developer Checklist

General

  • Code is appropriately commented, particularly in hard-to-understand areas
  • Repository documentation has been updated (Readme.md) with additional steps required for a local environment setup.
  • No console.log or related logging is added.
  • No code is repeated/duplicated in violation of DRY. The exception to this is for new (MVP/Prototype) functionality where the abstraction layer may not be clear (comments should be added to explain the violation of DRY in these scenarios).
  • Documented with TSDoc all library and controller new functions

Frontend Changes

  • No new styling is added through CSS files (Unless it's a bugfix/hotfix)
  • All types are added correctly

Tests

  • All existing unit and end to end tests pass across all services
  • Unit and end to end tests have been added to ensure backend APIs behave as expected

Merge Request Review Checklist

  • An issue is linked to this PR and these changes meet the requirements outlined in the linked issue(s)
  • High risk and core workflows have been tested and verified in a local environment.
  • Enhancements or opportunities to improve performance, stability, security or code readability have been noted and documented in JIRA issues if not being addressed.
  • Any dependent changes have been merged and published in downstream modules
  • Changes to multiple services can be deployed in parallel and independently. If not, changes should be broken out into separate merge requests and deployed in order.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
18.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Migrate component ToggleSection.tsx - Import { Radio }

1 participant