Merged
Conversation
|
thesocialdev
approved these changes
Jan 20, 2025
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Basically, I set the initial value of the state to false, and in the useEffect, I performed a check on the size of the speech relative to the window size. If it was larger, it would mean the speech is scrollable and, therefore, the state would be set to true. Now, the default value is false, and it will only be set to true if the speech is scrollable.
Fixes #1784
Type of change
Testing
Go to the ClaimView page with a speech long enough to require scrolling the screen to read it entirely.
Developer Checklist
General
console.logor related logging is added.Frontend Changes
Backend Changes
Tests
Merge Request Review Checklist