Skip to content

Migrate Select Components#1792

Merged
thesocialdev merged 5 commits intostagefrom
migrate-selects
Jan 26, 2025
Merged

Migrate Select Components#1792
thesocialdev merged 5 commits intostagefrom
migrate-selects

Conversation

@lucaslobatob
Copy link
Collaborator

@lucaslobatob lucaslobatob commented Jan 21, 2025

Description

In this PR I changed two selects on the platform, the first was from the ClaimReviewSelect.tsx file, where the functionality is to select the classification of the section that is being reviewed, the second file is from SelectLanguage.tsx, it is a select to choose which language the user wants on the platform.

Fixes #1583 #1592

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Existing feature enhancement (non-breaking change which modifies existing functionality)

Testing

ClaimReviewSelect Test:

  1. Be logged in to the platform;
  2. Create a new affirmation or enter an affirmation that has not yet been reviewed;
  3. Select the section to be reviewed;
  4. Choose a reviewer;
  5. The reviewer completes the form and uses select to select the review of the claim.

SelectLanguage Test:

  1. Enter the platform;
  2. Click on the flag to select the language.

PDF DOCUMENT:
Migrate-selects.odt

Developer Checklist

General

  • Code is appropriately commented, particularly in hard-to-understand areas
  • Repository documentation has been updated (Readme.md) with additional steps required for a local environment setup.
  • No console.log or related logging is added.
  • No code is repeated/duplicated in violation of DRY. The exception to this is for new (MVP/Prototype) functionality where the abstraction layer may not be clear (comments should be added to explain the violation of DRY in these scenarios).
  • Documented with TSDoc all library and controller new functions

Frontend Changes

  • No new styling is added through CSS files (Unless it's a bugfix/hotfix)
  • All types are added correctly

Tests

  • All existing unit and end to end tests pass across all services
  • Unit and end to end tests have been added to ensure backend APIs behave as expected

Merge Request Review Checklist

  • An issue is linked to this PR and these changes meet the requirements outlined in the linked issue(s)
  • High risk and core workflows have been tested and verified in a local environment.
  • Enhancements or opportunities to improve performance, stability, security or code readability have been noted and documented in JIRA issues if not being addressed.
  • Any dependent changes have been merged and published in downstream modules
  • Changes to multiple services can be deployed in parallel and independently. If not, changes should be broken out into separate merge requests and deployed in order.

@sonarqubecloud
Copy link

@lucaslobatob lucaslobatob marked this pull request as ready for review January 23, 2025 18:34
@thesocialdev thesocialdev merged commit 0bb2e51 into stage Jan 26, 2025
7 checks passed
@thesocialdev thesocialdev deleted the migrate-selects branch January 26, 2025 12:22
@thesocialdev thesocialdev mentioned this pull request Jan 26, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: QA

Development

Successfully merging this pull request may close these issues.

Migrate component ClaimReviewSelect.tsx - Import { Select }

2 participants