Skip to content

Migrating BaseList and its skeletons#1793

Merged
thesocialdev merged 2 commits intostagefrom
migrating-baseList-and-its-skeletons
Jan 22, 2025
Merged

Migrating BaseList and its skeletons#1793
thesocialdev merged 2 commits intostagefrom
migrating-baseList-and-its-skeletons

Conversation

@LuizFNJ
Copy link
Collaborator

@LuizFNJ LuizFNJ commented Jan 22, 2025

Description

In this PR, I replaced the Ant Design List component used in BaseList.tsx. Since this component is used in several places, I had to make some adjustments where it was called. I preserved the old layout and design. Along the way, I also fixed some issues for smaller screen resolutions. In the documentation, you can see how the pages and their skeletons turned out.

Testing

To test, you would need to visit each of the components listed in the documentation and verify their responsiveness and behavior as a list. In some cases, I replaced Ant Design texts with Material-UI ones, but overall, the focus should be on testing the responsiveness of the listed pages.

Components:

A visual document outlining which visual parts of the site need to be tested:
Testar BaseList e Skeletons.pdf

closes #1756 , closes #1755 , closes #1754 , closes #1753 , closes #1752 , closes #1723 , closes #1716 , closes #1675 , closes #1593

@LuizFNJ LuizFNJ requested a review from thesocialdev as a code owner January 22, 2025 12:13
@LuizFNJ LuizFNJ force-pushed the migrating-baseList-and-its-skeletons branch from e24563e to d686142 Compare January 22, 2025 12:30
@sonarqubecloud
Copy link

@LuizFNJ
Copy link
Collaborator Author

LuizFNJ commented Jan 22, 2025

Quality Gate Passed Quality Gate passed

Issues 1 New issue 0 Accepted issues

Measures 0 Security Hotspots 0.0% Coverage on New Code 0.0% Duplication on New Code

See analysis details on SonarQube Cloud

It seems they reported that I need to reduce cognitive load, and from what I understand, it has to do with the paths the component can take. I only kept the old paths, but since the Ant Design List doesn't have some native properties, I had to implement them within the component itself using conditionals. Question: Does it make sense to compact the List into another component, and would that resolve this cognitive load issue? @thesocialdev @caneppelevitor @pepermao

@thesocialdev thesocialdev merged commit 1d2bf3e into stage Jan 22, 2025
6 of 7 checks passed
@thesocialdev thesocialdev mentioned this pull request Jan 26, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment