Skip to content

Migrate Button component from Antd to MUI#1804

Merged
thesocialdev merged 1 commit intostagefrom
migrate-buttons
Feb 5, 2025
Merged

Migrate Button component from Antd to MUI#1804
thesocialdev merged 1 commit intostagefrom
migrate-buttons

Conversation

@lucaslobatob
Copy link
Collaborator

Description

Button.tsx: Replaced Ant Design's Button with Material-UI's Button in the project.

Fixes #1505

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Existing feature enhancement (non-breaking change which modifies existing functionality)

Testing

1. Be logged into the platform;
2. Click on any button within the platform; and
3. See if you are redirected to the correct page that the button corresponds to.

Developer Checklist

General

  • Code is appropriately commented, particularly in hard-to-understand areas
  • Repository documentation has been updated (Readme.md) with additional steps required for a local environment setup.
  • No console.log or related logging is added.
  • No code is repeated/duplicated in violation of DRY. The exception to this is for new (MVP/Prototype) functionality where the abstraction layer may not be clear (comments should be added to explain the violation of DRY in these scenarios).
  • Documented with TSDoc all library and controller new functions

Frontend Changes

  • No new styling is added through CSS files (Unless it's a bugfix/hotfix)
  • All types are added correctly

Tests

  • All existing unit and end to end tests pass across all services
  • Unit and end to end tests have been added to ensure backend APIs behave as expected

Merge Request Review Checklist

  • An issue is linked to this PR and these changes meet the requirements outlined in the linked issue(s)
  • High risk and core workflows have been tested and verified in a local environment.
  • Enhancements or opportunities to improve performance, stability, security or code readability have been noted and documented in JIRA issues if not being addressed.
  • Any dependent changes have been merged and published in downstream modules
  • Changes to multiple services can be deployed in parallel and independently. If not, changes should be broken out into separate merge requests and deployed in order.

@sonarqubecloud
Copy link

@lucaslobatob lucaslobatob marked this pull request as ready for review January 29, 2025 09:45
@thesocialdev
Copy link
Collaborator

@lucaslobatob the cypress tests are failing with this change

@thesocialdev
Copy link
Collaborator

@lucaslobatob I'm merging but the cypress tests are failing. We need a new issue just to deal with cypress afterwards.

@thesocialdev thesocialdev merged commit e5166fa into stage Feb 5, 2025
6 of 7 checks passed
@thesocialdev thesocialdev deleted the migrate-buttons branch February 5, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: QA

Development

Successfully merging this pull request may close these issues.

Migrate component Button.tsx - Import { Button, ButtonProps }

2 participants