Skip to content

Migrate Drawers to Material UI#1807

Merged
thesocialdev merged 1 commit intostagefrom
migrate-drawer
Feb 5, 2025
Merged

Migrate Drawers to Material UI#1807
thesocialdev merged 1 commit intostagefrom
migrate-drawer

Conversation

@lucaslobatob
Copy link
Collaborator

Description

The Drawer component has migrated to Material UI, from the files Sidebar.tsx and LargeDrawer.tsx, replacing the positioning property with anchor, maintaining the same functions, styled with sx and removing the closable property, since in MUI the close button can be omitted directly.

Fixes #1521 #1515

Type of change

  • New feature (non-breaking change which adds functionality)

Testing

*First Test from Sidebar:

  1. Open the Aletheia platform;
  2. Click on the header button in the top left corner.*

*Second Test from LargeDrawer

  1. Open the Aletheia platform;
  2. Log in;
  3. Create an affirmation or join an existing one;
  4. Click on the paragraph that will be reviewed.*

Visual Document
Migrate-drawer.pdf

Developer Checklist

General

  • No console.log or related logging is added.

Frontend Changes

  • No new styling is added through CSS files (Unless it's a bugfix/hotfix)
  • All types are added correctly

Tests

  • All existing unit and end to end tests pass across all services
  • Unit and end to end tests have been added to ensure backend APIs behave as expected

Merge Request Review Checklist

  • An issue is linked to this PR and these changes meet the requirements outlined in the linked issue(s)
  • High risk and core workflows have been tested and verified in a local environment.
  • Enhancements or opportunities to improve performance, stability, security or code readability have been noted and documented in JIRA issues if not being addressed.
  • Any dependent changes have been merged and published in downstream modules
  • Changes to multiple services can be deployed in parallel and independently. If not, changes should be broken out into separate merge requests and deployed in order.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 4, 2025

@thesocialdev
Copy link
Collaborator

thesocialdev commented Feb 5, 2025

@lucaslobatob I'm merging this, but the cypress errors are increasing as we progress. We need to have a task just to deal with them.

@Keikonichi once this is tested in the test environment, please let me know.

@thesocialdev thesocialdev merged commit 66d2098 into stage Feb 5, 2025
6 of 7 checks passed
@thesocialdev thesocialdev deleted the migrate-drawer branch February 5, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: QA

Development

Successfully merging this pull request may close these issues.

Migrate component Sidebar.tsx - Import { Drawer }

2 participants