feat: Simplify the access to the editor in the fact-checking workflow#2046
Open
thesocialdev wants to merge 9 commits intostagefrom
Open
feat: Simplify the access to the editor in the fact-checking workflow#2046thesocialdev wants to merge 9 commits intostagefrom
thesocialdev wants to merge 9 commits intostagefrom
Conversation
caneppelevitor
requested changes
Oct 12, 2025
Collaborator
|
@thesocialdev I still need more time to properly review this PR, specially for the cypress erros that we are getting |
thesocialdev
changed the title
|
caneppelevitor
force-pushed
the
feature/centralized-rbac-permission-system
branch
from
8d61b28 to
cfae37b
Compare
- Add centralized permission system with useReviewTaskPermissions hook - Implement cross-checking comment rejection workflow with confirmRejection event - Fix visual editor filtering to exclude unnecessary fields from specific events - Add comprehensive debug mode for testing different user scenarios - Improve header chips readability and hide header when reports are published - Resolve assignee chips to display user names instead of IDs - Update translations for new confirmation and rejection workflows - Add comprehensive documentation for permission system architecture 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- DynamicReviewTaskForm now gets events from state machine (source of truth) - Use permissions as middleware to filter/check user capabilities - Permissions no longer override the state machine's event determination - Maintain proper separation of concerns: state machine defines what's possible, permissions define what's allowed 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
caneppelevitor
force-pushed
the
feature/centralized-rbac-permission-system
branch
from
d63db8c to
b59a83f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Key Features
useReviewTaskPermissionshook consolidates all permission logicTechnical Improvements
TypeError: event.reviewData.visualEditor.toJSON is not a functionby filtering visual editor from comment-only eventsTest plan
🤖 Generated with Claude Code