fix: allow users to remove topics from verification requests#2216
Merged
caneppelevitor merged 3 commits intostagefrom Feb 9, 2026
Merged
fix: allow users to remove topics from verification requests#2216caneppelevitor merged 3 commits intostagefrom
caneppelevitor merged 3 commits intostagefrom
Conversation
caneppelevitor
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where removing topics from Verification Requests was failing.
The Problem:
The removal logic was filtering topics based only on the
topic.valueproperty. While this worked for Sentences and Images (where topics are stored as objects), it failed for Verification Requests because the data structure differs across these collections.The Fix:
I updated the filter logic to handle both data structures by checking both
topic.valueandtopic.wikidataId. This ensures the removal functionality is compatible with:Technical Debt:
During this fix, I discovered an inconsistency in how topics are stored across the platform (Object IDs vs. Inline Objects). I have added proper TypeScript typing for both cases and created a dedicated issue #2215 to discuss and standardize this architecture in a future.
Related Ticket #2195
Related Refactor Issue: #2215
Type of change
#Testing
To verify the fix, please test the topic removal in the following three areas:
Developer Checklist
General
console.logor related logging is added.Frontend Changes
Backend Changes
Tests
Test IDs
Merge Request Review Checklist