Skip to content

fix: populate href prop in getServerSideProps for social sharing#2280

Merged
caneppelevitor merged 2 commits intostagefrom
fix/share-buttons-on-homepage
Mar 3, 2026
Merged

fix: populate href prop in getServerSideProps for social sharing#2280
caneppelevitor merged 2 commits intostagefrom
fix/share-buttons-on-homepage

Conversation

@LuizFNJ
Copy link
Collaborator

@LuizFNJ LuizFNJ commented Feb 27, 2026

Description

Fixes an issue where the href prop was not being passed to the HomePage component in getServerSideProps, preventing social media buttons from having a valid URL to share.

Related Ticket #2272

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

  1. Navigate to the Homepage.
  2. Click on each social media button (Facebook, Twitter, WhatsApp, Telegram).
  3. Verify that the shared URL corresponds to the current page URL.

(See attached video demonstrating functionality on homepage)
on home page:

Screen.Recording.2026-02-27.at.23.59.15.mov

Developer Checklist

General

  • Code is appropriately commented, particularly in hard-to-understand areas
  • Repository documentation has been updated (Readme.md) with additional steps required for a local environment setup.
  • No console.log or related logging is added.
  • No code is repeated/duplicated in violation of DRY. The exception to this is for new (MVP/Prototype) functionality where the abstraction layer may not be clear (comments should be added to explain the violation of DRY in these scenarios).
  • Documented with TSDoc all library and controller new functions

Frontend Changes

  • No new styling is added through CSS files (Unless it's a bugfix/hotfix)
  • All types are added correctly

Backend Changes

  • All endpoints are appropriately secured with Middleware authentication
  • All new endpoints have a interface schema defined

Tests

  • All existing unit and end to end tests pass across all services
  • Unit and end to end tests have been added to ensure backend APIs behave as expected

Test IDs

  • Include the test ID when adding new tasks or components.
  • Check that test IDs are present in the modified components.

Merge Request Review Checklist

  • An issue is linked to this PR and these changes meet the requirements outlined in the linked issue(s)
  • High risk and core workflows have been tested and verified in a local environment.
  • Enhancements or opportunities to improve performance, stability, security or code readability have been noted and documented in Project do Github issues if not being addressed.
  • Any dependent changes have been merged and published in downstream modules
  • Changes to multiple services can be deployed in parallel and independently. If not, changes should be broken out into separate merge requests and deployed in order.

@caneppelevitor caneppelevitor merged commit 1dd171c into stage Mar 3, 2026
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: QA

Development

Successfully merging this pull request may close these issues.

2 participants