This repository was archived by the owner on Oct 19, 2020. It is now read-only.
Fix the productName value when attributes are used#121
Open
david-spaeth wants to merge 3 commits intoAlexDisler:masterfrom
Open
Fix the productName value when attributes are used#121david-spaeth wants to merge 3 commits intoAlexDisler:masterfrom
david-spaeth wants to merge 3 commits intoAlexDisler:masterfrom
Conversation
added 3 commits
March 7, 2018 17:30
Fix the bad value of `productName` variable if `short` attribute has use in `name` tag Cordova allow `short` attribute in `name` tag. See: https://cordova.apache.org/docs/en/latest/config_ref/#short-name
|
Was about to create the same pull request. Merging this is much appreciated since using Also the fix done for android old paths is a good one that prevents manual copying for older setups using latest version of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the bad value of
productNamevariable ifshortattribute has use innametagCordova allow
shortattribute innametag. See: https://cordova.apache.org/docs/en/latest/config_ref/#short-name