This repository was archived by the owner on Oct 19, 2020. It is now read-only.
adding new icon locations for later versions of cordova#139
Open
freakypie wants to merge 3 commits intoAlexDisler:masterfrom
Open
adding new icon locations for later versions of cordova#139freakypie wants to merge 3 commits intoAlexDisler:masterfrom
freakypie wants to merge 3 commits intoAlexDisler:masterfrom
Conversation
|
Funny, ran into this issue today too, was about to submit a PR and found this! Nice one @freakypie 👍 |
|
Ran into this issue, too. Thank you @freakypie. |
|
Thank you @freakypie, this issue working fine. @AlexDisler, can you accept this PR? I tested this PR and this solves the problem with the icons on both iOS and Android. |
|
Hi guys, I tested this version of the code and it's working just fine. Solved the issues for both iOS and Android! Thanks @freakypie . @AlexDisler , can you accept this PR? It would be great help. |
|
Thanks for the fixup @freakypie It just solved the problem I was having on both ios and android. @AlexDisler can you merge this PR please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.