Skip to content

Support negated filters on one-to-one and many-to-one Relationships #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support negated filters on one-to-one and many-to-one Relationships #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions relativity/fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,12 +405,12 @@ def get_path_info(self, filtered_relation=None):
if django.VERSION < (2, 0):
to_opts = self.rel.to._meta
from_opts = self.model._meta
return [PathInfo(from_opts, to_opts, (to_opts.pk,), self, True, False)]
return [PathInfo(from_opts, to_opts, (to_opts.pk,), self, self.multiple, False)]
to_opts = self.remote_field.model._meta
from_opts = self.model._meta
return [
PathInfo(
from_opts, to_opts, (to_opts.pk,), self, True, False, filtered_relation
from_opts, to_opts, (to_opts.pk,), self, self.multiple, False, filtered_relation
)
]

Expand Down
23 changes: 23 additions & 0 deletions tests/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,29 @@ def test_single_reverse(self):
self.assertIsNone(node_3.next)
self.assertIsNone(node_1.prev)

def test_many_to_one_exclude_forward(self):
qs = CartItem.objects.exclude(product__colour="red")

self.assertEqual(qs.count(), 1)

def test_single_exclude_forward(self):
node_1 = LinkedNode.objects.create(
name="first node",
prev_id=None,
)
node_2 = LinkedNode.objects.create(
name="next node",
prev_id=node_1.id,
)
node_3 = LinkedNode.objects.create(
name="last node",
prev_id=node_2.id,
)

qs = LinkedNode.objects.exclude(next__name__contains="last")

self.assertEqual(qs.count(), 2)

def test_not_nullable(self):
item = CartItem.objects.create(
pk=4,
Expand Down