Initiate module for cell-type-ewings#131
Conversation
for more information, see https://pre-commit.ci
|
Hmmm is there a way to get it to skip git hooks here? This change 82ae052 breaks the code... |
This reverts commit 82ae052.
for more information, see https://pre-commit.ci
This reverts commit e9516ba.
turn back on autofix
Oh, that is annoying. What we really want to do here is to add a rule for |
jashapiro
left a comment
There was a problem hiding this comment.
The overall structure here looks good. I had some suggestions about formatting and output.
My other question is about inputs and next steps: is this module also going to use the consensus results? I don't think anything needs to happen with that now, but I was curious, thinking about how the next steps will go.
modules/cell-type-ewings/README.md
Outdated
|
|
||
| Links to specific original scripts used in this module: | ||
|
|
||
| - `01-aucell.R`: <https://github.com/AlexsLemonade/OpenScPCA-analysis/blob/main/analyses/cell-type-ewings/scripts/aucell-ews-signatures/01-aucell.R> |
There was a problem hiding this comment.
Use a tag or permalink here, please.
nextflow_schema.json
Outdated
| }, | ||
| "cell_type_ewings_msigdb_list": { | ||
| "type": "string", | ||
| "default": "https://raw.githubusercontent.com/AlexsLemonade/OpenScPCA-analysis/refs/tags/v0.2.2/analyses/cell-type-ewings/references/msigdb-gene-sets.tsv" |
There was a problem hiding this comment.
Can you add all of the validataion info here and for the other files? I made an attempt at the description for this one, but please update it as needed.. A description for the max_rank would also be useful.
| "default": "https://raw.githubusercontent.com/AlexsLemonade/OpenScPCA-analysis/refs/tags/v0.2.2/analyses/cell-type-ewings/references/msigdb-gene-sets.tsv" | |
| "default": "https://raw.githubusercontent.com/AlexsLemonade/OpenScPCA-analysis/refs/tags/v0.2.2/analyses/cell-type-ewings/references/msigdb-gene-sets.tsv" | |
| "pattern": "\\.tsv$", | |
| "format": "file-path", | |
| "mimetype": "text/tab-separated-values", | |
| "description": "Table of MSigDB gene sets" |
Co-authored-by: Joshua Shapiro <josh.shapiro@ccdatalab.org>
Co-authored-by: Joshua Shapiro <josh.shapiro@ccdatalab.org>
…t1' into allyhawkins/ewing-cell-types-part1
Yes the plan is to use the consensus cell types. I think the next step will be a process that takes as input the consensus cell types and the AUCell results and actually does the cell type assignment. That process will also take in a set of params that define the AUC thresholds to use for classifying cells. The output to that will be a TSV file with the cell type annotations. I also updated the validation sections of the schema file, fixed some of the links, and then uncommented out the other modules so this should be ready for another look. |
Towards #129
Here I am initiating the
cell-type-ewingsmodule and adding the first step, which is to runAUCellon every library using a set of gene sets fromMSigDBand custom gene sets.AUCellon gene signatures in thecell-type-ewingsmodule fromOpenScPCA-analysis.OpenScPCA-analysis, I did use the results from runningAUCellon the merged object, but because it's rank based for each cell, we should be able to do the same thing on the individual objects, assuming we use the same thresholds.aucMaxRankusing a percentage of detected genes, rather than providing a number. In thecell-type-ewingsmodule we ended up using theaucMaxRankequivalent to 1% of the total number of detected genes in the merged object. So I calculated that and set that as the default here, which is 425.NAvalues.OpenScPCA-analysis, similar to how we use the consensus cell type reference files.I did test this and things were successful!